Skip to content

fix(spec/flows): properly clean up storage on wallet connection failures and other smaller fixes - #823

Open
MichaelKohler wants to merge 1 commit into
mainfrom
properly-cleanup
Open

MichaelKohler wants to merge 1 commit into
mainfrom
properly-cleanup

Conversation

@MichaelKohler

Copy link
Copy Markdown
Collaborator

This PR tackles proper cleanup on wallet connection errors. I fixed a few things along the way as well, so it got a bit bigger:

  • Combines storing wallet address details, grant and maxRateOfPay in one algorithm.
  • Clarified that connecting a wallet is not a switch operation, we first disconnect and then connect again.
  • Properly uses the new abort algorithm in the connect algorithm.
  • Fixes the pendingGrant value type.
  • Adjust wait in polling based on latest response, not based on initial first response.
  • Fixed not closed section
  • Drive-by fix of wallet address return type check
  • Adjust continue wait timeout to 5 seconds by default (as GNAP requires)
  • Handle errors properly in polling, as otherwise a transient network error could abort the setup.
  • Fixes the fetch algorithm parameters
  • Fixed issue with reading responses too soon

Closes #802.

@netlify

netlify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit 5eea613
🔍 Latest deploy log https://app.netlify.com/projects/webmonetization-preview/deploys/6b004bdff642720d3964255b
😎 Deploy Preview https://deploy-preview-823--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly clean up on failure

1 participant